Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and minor improvements #82

Merged
merged 3 commits into from
May 19, 2020
Merged

Bug fixes and minor improvements #82

merged 3 commits into from
May 19, 2020

Conversation

IPRIT
Copy link
Contributor

@IPRIT IPRIT commented May 17, 2020

  • Removed unnecessary console output;
  • A better _event function

@IPRIT
Bug fixes and minor improvements
abb36fc 
* Removed unnecessary console output;
* A better `_event` function
@knopki knopki requested review from nomad605dis and yurybotov May 17, 2020 09:58
yurybotov
yurybotov approved these changes May 17, 2020
View reviewed changes
Copy link
Contributor

@yurybotov yurybotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

knopki
knopki requested changes May 17, 2020
View reviewed changes
modules/@amperka/server.js Outdated Show resolved Hide resolved
modules/@amperka/server.js Outdated Show resolved Hide resolved
IPRIT and others added 2 commits May 19, 2020 15:39
@IPRIT @knopki
Trailing space
07b08ee 
Co-authored-by: Sergey Korolev <[email protected]>
@IPRIT @knopki
Trailing space
ea16227 
Co-authored-by: Sergey Korolev <[email protected]>
@IPRIT IPRIT requested a review from knopki May 19, 2020 12:39
knopki
knopki approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@knopki knopki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@knopki knopki merged commit b92dc8d into amperka:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurybotov yurybotov yurybotov approved these changes

@knopki knopki knopki approved these changes

@nomad605dis nomad605dis Awaiting requested review from nomad605dis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IPRIT @knopki @yurybotov